Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsed Event Sub-Processes do not show the type #2080

Open
rajgoel opened this issue Jan 16, 2024 · 7 comments
Open

Collapsed Event Sub-Processes do not show the type #2080

rajgoel opened this issue Jan 16, 2024 · 7 comments
Labels
backlog Queued in backlog bug Something isn't working pr welcome We rely on a community contribution to improve this. rendering

Comments

@rajgoel
Copy link

rajgoel commented Jan 16, 2024

Describe the Bug

According to Table 12.16, p. 388 of the spec, collapsed event-subprocesses having a unique start event with event definition should be depicted with an icon representing the start event type. This is not shown in the modeler.

Steps to Reproduce

Load a model with a collapsed submodule or collapse an event subprocess using the module https://github.com/bpmn-os/bpmn-js-collapse-event-subprocess.

Expected Behavior

If a unique start event is provided, the collapsed event subprocess should be decorated with an icon representing the start event type.

Environment

  • Library version: 16.3.2

Related to #690

@rajgoel rajgoel added the bug Something isn't working label Jan 16, 2024
@nikku
Copy link
Member

nikku commented Jan 17, 2024

Thanks for opening this issue.

Consider a contribution if you want to move this topic forward.

@nikku nikku added rendering pr welcome We rely on a community contribution to improve this. backlog Queued in backlog labels Jan 17, 2024
@rajgoel
Copy link
Author

rajgoel commented Jan 17, 2024

@nikku I just found a working solution and add it to https://github.com/bpmn-os/bpmn-js-collapse-event-subprocess/.

The only small problem is that a little bit of padding would be nice

CollapsedEventSubProcess

https://github.com/bpmn-os/bpmn-js-collapse-event-subprocess/blob/2bb965d4b3bb77778938bdd0475a4a2920d3d59c/CollapsedEventSubProcessDecorator.js#L55-L61

Maybe you have an idea how to move the decorator a bit away from the boundary.

@nikku
Copy link
Member

nikku commented Jan 17, 2024

I'd ask you to file a feature request in the linked repository (which is outside of our sphere).

Never mind my previous comment. I've seen you're the owner.

@rajgoel
Copy link
Author

rajgoel commented Jan 17, 2024

Hi, the linked repository is mine where I have all my BPMN related projects. It would be great to transfer this to bpmn-js.

@nikku
Copy link
Member

nikku commented Jan 17, 2024

You can wrap whatever is rendered into a SVG group with a transform (x, y) to pad it.

@rajgoel
Copy link
Author

rajgoel commented Jan 17, 2024

Thanks a lot for the hint, helped me figure out to do this. Looks much better now.

CollapsedEventSubProcess

I think this could be a useful addition to bpmn-js as it affects implementation of the standard. Do you want to take over ownership of this module, or what is your policy concerning user provided modules?

@NPDeehan
Copy link

Just wanted to drop a comment to say that this has been recently requested by some community folk. Great to see your work on this @rajgoel thanks!
https://forum.camunda.io/t/collapsed-event-sub-process-clarification/49904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working pr welcome We rely on a community contribution to improve this. rendering
Development

No branches or pull requests

3 participants