Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to type services and events #2121

Closed
1 task done
nikku opened this issue Mar 22, 2024 · 2 comments · Fixed by #2153
Closed
1 task done

Add ability to type services and events #2121

nikku opened this issue Mar 22, 2024 · 2 comments · Fixed by #2153
Assignees
@nikku
Labels
documentation Improvements or additions to documentation enhancement New feature or request spring cleaning Could be cleaned up one day

Comments

@nikku
Copy link
Member

nikku commented Mar 22, 2024 •
edited

Is your feature request related to a problem? Please describe.

bpmn-io/diagram-js#862 allows us to type diagram services and events, however we don't use that feature yet.

Describe the solution you'd like

  • As a user I'm able to provide custom types for public bpmn-js services and events

Describe alternatives you've considered

None.

Additional context

This will further facilitate our typings for discovery / ease of use.
@nikku nikku added enhancement New feature or request documentation Improvements or additions to documentation spring cleaning Could be cleaned up one day labels Mar 22, 2024
@nikku nikku self-assigned this Mar 25, 2024
@nikku nikku added the ready Ready to be worked on label Mar 25, 2024
@nikku
Copy link
Member Author

nikku commented Mar 25, 2024

Moving to ready as a post release activity.

@nikku nikku mentioned this issue Apr 29, 2024
Merged
3 tasks
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on needs review Review pending and removed ready Ready to be worked on in progress Currently worked on labels Apr 29, 2024
nikku added a commit that referenced this issue Apr 29, 2024
@nikku
feat: allow to type services and events
f4f87de 
This PR builds on upon diagram-js provided service and event typing:

* bpmn-io/diagram-js#862

It allows you to specify (public) types exposed by your BPMN toolkit
trough a ServiceMap. Events exposed are parsed from the EventBus
dynamic types.

Closes #2121
nikku added a commit that referenced this issue Apr 29, 2024
@nikku
feat: allow to type services and events
707ad8a 
This PR builds on upon diagram-js provided service and event typing:

* bpmn-io/diagram-js#862

It allows you to specify (public) types exposed by your BPMN toolkit
trough a ServiceMap. Events exposed are parsed from the EventBus
dynamic types.

Closes #2121
nikku added a commit that referenced this issue Apr 29, 2024
@nikku
feat: allow to type services and events
5c72257 
This PR builds on upon diagram-js provided service and event typing:

* bpmn-io/diagram-js#862

It allows you to specify (public) types exposed by your BPMN toolkit
trough a ServiceMap. Events exposed are parsed from the EventBus
dynamic types.

Closes #2121
nikku added a commit that referenced this issue Apr 30, 2024
@nikku
feat: allow to type services and events
edfec4c 
This PR builds on upon diagram-js provided service and event typing:

* bpmn-io/diagram-js#862

It allows you to specify (public) types exposed by your BPMN toolkit
trough a ServiceMap. Events exposed are parsed from the EventBus
dynamic types.

Closes #2121
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 30, 2024
@nikku nikku changed the title Add basic typing of essential services and events Add ability to type services and events Apr 30, 2024
@nikku nikku mentioned this issue Apr 30, 2024
Open
2 tasks
@nikku
Copy link
Member Author

nikku commented Apr 30, 2024

Spun of out of the box types to separate issue: #2155.

@philippfromme philippfromme mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
documentation Improvements or additions to documentation enhancement New feature or request spring cleaning Could be cleaned up one day
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Type hints bpmn-io/bpmn-js
1 participant
@nikku