Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for replacement using actual target #1699

Merged
merged 1 commit into from Jul 13, 2022
Merged

fix: check for replacement using actual target #1699

merged 1 commit into from Jul 13, 2022

Conversation

philippfromme
Copy link
Contributor

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 13, 2022
@barmac
Copy link
Member

barmac commented Jul 13, 2022 •
edited

As a fix, this should be targeted at master.

barmac
barmac approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to break it and wasn't able to. The test case looks good as well.

✅

@barmac barmac self-requested a review July 13, 2022 11:21
@barmac barmac changed the base branch from develop to master July 13, 2022 11:21
@barmac
Copy link
Member

barmac commented Jul 13, 2022

As a fix, this should be targeted at master.

I did it myself.

@fake-join fake-join bot merged commit 9b66c97 into master Jul 13, 2022
@fake-join fake-join bot deleted the properly-replace-elements-on-create branch July 13, 2022 11:31
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 13, 2022
@philippfromme
Copy link
Contributor Author

Thanks, mate!

@philippfromme philippfromme mentioned this pull request Jul 13, 2022
Closed
This was referenced Aug 3, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@marstamm marstamm Awaiting requested review from marstamm

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus

Assignees

@philippfromme philippfromme

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy/paste of event-subprocess turns non-interrupting message start event to untyped start event
2 participants
@philippfromme @barmac