Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass additional modules via common config #694

Open
barmac opened this issue Mar 23, 2022 · 0 comments
Open

Allow to pass additional modules via common config #694

barmac opened this issue Mar 23, 2022 · 0 comments
Labels
backlog Queued in backlog enhancement New feature or request

Comments

@barmac
Copy link
Member

barmac commented Mar 23, 2022

Is your feature request related to a problem? Please describe.

Because I cannot pass additional module via common config now, I have to know upfront the names of all of the viewers to correctly configure a multi-viewer module, e.g.

      modeler = new Modeler({
        container: container,
        common: {
          executionPlatform: {
            name: 'Camunda Platform',
            version: '7.16.0'
          }
        },
        drd: {
          additionalModules: [
            ExecutionPlatformModule
          ]
        },
        decisionTable: {
          additionalModules: [
            ExecutionPlatformModule
          ]
        },
        literalExpression: {
          additionalModules: [
            ExecutionPlatformModule
          ]
        },
        moddleExtensions: {
          modeler: ModelerModdleExtension
        }
      });

Describe the solution you'd like

Allow to pass additional modules via common.additionalModules:

      modeler = new Modeler({
        container: container,
        common: {
          additionalModules: [
            ExecutionPlatformModule
          ],
          executionPlatform: {
            name: 'Camunda Platform',
            version: '7.16.0'
          }
        },
        moddleExtensions: {
          modeler: ModelerModdleExtension
        }
      });

The common modules should be passed to the injector before the viewer's modules so that they can be overriden.

Describe alternatives you've considered

Leave it as it is.

Additional context

None.

@barmac barmac added enhancement New feature or request backlog Queued in backlog labels Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request
Development

No branches or pull requests

1 participant