Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the semantics of the properties panel header #207

Open
rpkoller opened this issue Jan 15, 2023 · 1 comment
Open

Improve the semantics of the properties panel header #207

rpkoller opened this issue Jan 15, 2023 · 1 comment
Labels
a11y backlog Queued in backlog enhancement New feature or request good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day

Comments

@rpkoller
Copy link

Is your feature request related to a problem? Please describe

At the moment the header of the properties panel is just using divs for the markup. in Camunda the title of the model is marked up with an h3 in the properties panel but the section underneath with start event and the beginning is just wrapped in divs:
Screen Shot 2023-01-15 at 16 34 06
In ECA in Drupal which doesn't have an h3 for the model title in the properties panel there are just the divs:
Screen Shot 2023-01-15 at 16 35 03

Describe the solution you'd like
Would it make sense to change the html element for the div with the class bio-properties-panel-header to header. And change the div with the class bio-properties-panel-header-type to a heading element. the only question how to handle the sub heading the beginning in the screenshots with the class bio-properties-panel-header-label. wrap it in another heading or wrap both in a single heading and use for one of the them something like thestrong tag. like option 4 in the following article https://css-tricks.com/html-for-subheadings-and-headings/

Describe alternatives you've considered

Additional context

@rpkoller rpkoller added the enhancement New feature or request label Jan 15, 2023
@barmac
Copy link
Member

barmac commented Jan 20, 2023

Thank you for your suggestions. Indeed it will make more sense if we use semantic HTML in the properties panel.

@barmac barmac added backlog Queued in backlog a11y good first issue Good for newcomers spring cleaning Could be cleaned up one day pr welcome We rely on a community contribution to improve this. labels Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y backlog Queued in backlog enhancement New feature or request good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day
Development

No branches or pull requests

2 participants