Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEEL editor entry uses a lot of space for large content initially #260

Open
pinussilvestrus opened this issue Jul 18, 2023 · 3 comments
Open
Labels
backlog Queued in backlog bug Something isn't working needs discussion Needs further discussion

Comments

@pinussilvestrus
Copy link
Contributor

Describe the Bug

This was identified during the kickoff of the FEEL popup editor (https://github.com/camunda/team-hto/issues/262#issuecomment-1638203305)

The FEEL editor entry sets the initial height to fit its content. This leads to take a lot of space for bigger expressions.

image

Steps to Reproduce

  1. Select an element which includes a large FEEL expression
  2. The the entry takes a lot of space

Expected Behavior

We need to discuss what is our expected behavior here. One option could be to set a max-height of 10 lines, or even accept the current behavior.

Environment

  • Host (Browser/Node version), if applicable: Chrome
  • OS: macOS Ventura 13.4
  • Library version: main
@pinussilvestrus pinussilvestrus added the bug Something isn't working label Jul 18, 2023
@pinussilvestrus
Copy link
Contributor Author

cc @christian-konrad

@nikku
Copy link
Member

nikku commented Jul 18, 2023

@pinussilvestrus My take is: Let us accept the current behavior. Rationale:

  • FEEL statements, due to the language being an expression language tend to be rather short.
  • In places where scripts are complex we don't want to hide that crucial information. If needed host sections can be collapsed, but generally speaking the properties panel architecture absolutely supports (and encourages) scrolling.
  • For me as a developer it is not reasonable to CLICK into each section to show the full contents of a FEEL statement, and or move to a separate editor to see or edit it. In fact we want to accomplish the exact opposite.

@nikku nikku added the needs discussion Needs further discussion label Jul 19, 2023
@pinussilvestrus
Copy link
Contributor Author

pinussilvestrus commented Jul 24, 2023

@pinussilvestrus My take is: Let us accept the current behavior

I agree ✅ and wait for feedback

@marstamm marstamm added the backlog Queued in backlog label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working needs discussion Needs further discussion
Development

No branches or pull requests

3 participants