Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: brainbits/eslint-config-brainbits
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.1.9
Choose a base ref
...
head repository: brainbits/eslint-config-brainbits
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.1.10
Choose a head ref
  • 3 commits
  • 19 files changed
  • 2 contributors

Commits on Jan 15, 2024

  1. chore: change author in package.json

    Steven Weingärtner committed Jan 15, 2024
    Copy the full SHA
    db2841b View commit details
  2. fix(typescript): change @typescript-eslint/naming-convention settings

    This removes the strict modifier for camelCase and PascalCase names, allowing consecutive
    capital letters. This allows for properties like "myID" or "someZCoordinate".
    This also disables naiming conventions for all object literal properties in quotes, which is
    usefull when defining objects like HHTP Request-Headers and the like.
    Steven Weingärtner committed Jan 15, 2024
    Copy the full SHA
    1461193 View commit details
  3. v4.1.10

    Brainbits Bot committed Jan 15, 2024
    Copy the full SHA
    3eaab06 View commit details
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 4.1.10 (2024-01-15)


### Bug Fixes

* **typescript:** change @typescript-eslint/naming-convention settings ([1461193](https://github.com/brainbits/eslint-config-brainbits/commit/14611938cf8ccbce9e1812b7ef6b8ed912e085b7))





## 4.1.9 (2024-01-10)

**Note:** Version bump only for package eslint-config-brainbits-monorepo
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"lerna": "2.7.0",
"version": "4.1.9"
"version": "4.1.10"
}
34 changes: 17 additions & 17 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@
"main": "index.js",
"private": true,
"repository": "brainbits/eslint-config-brainbits",
"author": "Michael van Engelshoven <michael@van-engelshoven.de>",
"author": "brainbits GmbH <info@brainbits.net>",
"license": "MIT",
"workspaces": [
"packages/angular",
11 changes: 11 additions & 0 deletions packages/angular/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 4.1.10 (2024-01-15)


### Bug Fixes

* **typescript:** change @typescript-eslint/naming-convention settings ([1461193](https://github.com/brainbits/eslint-config-brainbits/commit/14611938cf8ccbce9e1812b7ef6b8ed912e085b7))





## 4.1.9 (2024-01-10)

**Note:** Version bump only for package eslint-config-brainbits-angular
2 changes: 1 addition & 1 deletion packages/angular/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-brainbits-angular",
"version": "4.1.9",
"version": "4.1.10",
"description": "Global angular eslint rules for Brainbits GmbH",
"main": "index.js",
"scripts": {
11 changes: 11 additions & 0 deletions packages/base/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 4.1.10 (2024-01-15)


### Bug Fixes

* **typescript:** change @typescript-eslint/naming-convention settings ([1461193](https://github.com/brainbits/eslint-config-brainbits/commit/14611938cf8ccbce9e1812b7ef6b8ed912e085b7))





## 4.1.9 (2024-01-10)

**Note:** Version bump only for package eslint-config-brainbits
2 changes: 1 addition & 1 deletion packages/base/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-brainbits",
"version": "4.1.9",
"version": "4.1.10",
"description": "Global eslint rules for Brainbits GmbH",
"main": "index.js",
"scripts": {
11 changes: 11 additions & 0 deletions packages/jest/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 4.1.10 (2024-01-15)


### Bug Fixes

* **typescript:** change @typescript-eslint/naming-convention settings ([1461193](https://github.com/brainbits/eslint-config-brainbits/commit/14611938cf8ccbce9e1812b7ef6b8ed912e085b7))





## 4.1.9 (2024-01-10)

**Note:** Version bump only for package eslint-config-brainbits-jest
2 changes: 1 addition & 1 deletion packages/jest/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-brainbits-jest",
"version": "4.1.9",
"version": "4.1.10",
"description": "Default eslint config for project using jest at Brainbits GmbH",
"main": "index.js",
"repository": "brainbits/eslint-config-brainbits",
11 changes: 11 additions & 0 deletions packages/react/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 4.1.10 (2024-01-15)


### Bug Fixes

* **typescript:** change @typescript-eslint/naming-convention settings ([1461193](https://github.com/brainbits/eslint-config-brainbits/commit/14611938cf8ccbce9e1812b7ef6b8ed912e085b7))





## 4.1.9 (2024-01-10)

**Note:** Version bump only for package eslint-config-brainbits-react
4 changes: 2 additions & 2 deletions packages/react/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-brainbits-react",
"version": "4.1.9",
"version": "4.1.10",
"description": "Global react eslint rules for Brainbits GmbH",
"main": "index.js",
"scripts": {
@@ -15,7 +15,7 @@
"license": "MIT",
"dependencies": {
"eslint-config-airbnb": "^19.0.4",
"eslint-config-brainbits": "^4.1.9"
"eslint-config-brainbits": "^4.1.10"
},
"peerDependencies": {
"eslint-plugin-jsx-a11y": "^6.2.3",
11 changes: 11 additions & 0 deletions packages/typescript-react/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 4.1.10 (2024-01-15)


### Bug Fixes

* **typescript:** change @typescript-eslint/naming-convention settings ([1461193](https://github.com/brainbits/eslint-config-brainbits/commit/14611938cf8ccbce9e1812b7ef6b8ed912e085b7))





## 4.1.9 (2024-01-10)

**Note:** Version bump only for package eslint-config-brainbits-typescript-react
6 changes: 3 additions & 3 deletions packages/typescript-react/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-brainbits-typescript-react",
"version": "4.1.9",
"version": "4.1.10",
"description": "Global typescript react eslint rules for Brainbits GmbH",
"main": "index.js",
"scripts": {
@@ -15,8 +15,8 @@
],
"license": "MIT",
"dependencies": {
"eslint-config-brainbits-react": "^4.1.9",
"eslint-config-brainbits-typescript": "^4.1.9"
"eslint-config-brainbits-react": "^4.1.10",
"eslint-config-brainbits-typescript": "^4.1.10"
},
"gitHead": "9d72dcf4aa03981901ce34b64ddea7e4ce56d55c"
}
11 changes: 11 additions & 0 deletions packages/typescript/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 4.1.10 (2024-01-15)


### Bug Fixes

* **typescript:** change @typescript-eslint/naming-convention settings ([1461193](https://github.com/brainbits/eslint-config-brainbits/commit/14611938cf8ccbce9e1812b7ef6b8ed912e085b7))





## 4.1.9 (2024-01-10)

**Note:** Version bump only for package eslint-config-brainbits-typescript
19 changes: 10 additions & 9 deletions packages/typescript/index.js
Original file line number Diff line number Diff line change
@@ -38,16 +38,17 @@ module.exports = {
camelcase: 'off',
'@typescript-eslint/naming-convention': [
'error',
{ selector: 'default', format: ['strictCamelCase'] },
{ selector: 'import', format: ['strictCamelCase', 'StrictPascalCase'] },
{ selector: 'variable', format: ['strictCamelCase', 'StrictPascalCase'] },
{ selector: 'variable', modifiers: ['const'], format: ['strictCamelCase', 'UPPER_CASE', 'StrictPascalCase'] },
{ selector: 'function', format: ['strictCamelCase', 'StrictPascalCase'] },
{ selector: 'parameter', format: ['strictCamelCase'], leadingUnderscore: 'allow' },
{ selector: 'memberLike', format: ['strictCamelCase', 'StrictPascalCase'] },
{ selector: 'memberLike', modifiers: ['private'], format: ['strictCamelCase', 'StrictPascalCase'], leadingUnderscore: 'allow' },
{ selector: 'default', format: ['camelCase'] },
{ selector: 'import', format: ['camelCase', 'PascalCase'] },
{ selector: 'variable', format: ['camelCase', 'PascalCase'] },
{ selector: 'variable', modifiers: ['const'], format: ['camelCase', 'UPPER_CASE', 'PascalCase'] },
{ selector: 'function', format: ['camelCase', 'PascalCase'] },
{ selector: 'parameter', format: ['camelCase'], leadingUnderscore: 'allow' },
{ selector: 'memberLike', format: ['camelCase', 'PascalCase'] },
{ selector: 'memberLike', modifiers: ['private'], format: ['camelCase', 'PascalCase'], leadingUnderscore: 'allow' },
{ selector: 'memberLike', filter: { regex: '^__typename', match: true }, format: null },
{ selector: 'typeLike', format: ['StrictPascalCase'] },
{ selector: 'typeLike', format: ['PascalCase'] },
{ selector: 'objectLiteralProperty', modifiers: ['requiresQuotes'], format: null },
],

// Replace Airbnb 'comma-spacing' rule with '@typescript-eslint' version
4 changes: 2 additions & 2 deletions packages/typescript/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-brainbits-typescript",
"version": "4.1.9",
"version": "4.1.10",
"description": "Global typescript eslint rules for Brainbits GmbH",
"main": "index.js",
"scripts": {
@@ -15,7 +15,7 @@
],
"license": "MIT",
"dependencies": {
"eslint-config-brainbits": "^4.1.9"
"eslint-config-brainbits": "^4.1.10"
},
"peerDependencies": {
"@typescript-eslint/eslint-plugin": "^5.38.1 || ^6.0.0",
11 changes: 11 additions & 0 deletions tests/react/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 4.1.10 (2024-01-15)


### Bug Fixes

* **typescript:** change @typescript-eslint/naming-convention settings ([1461193](https://github.com/brainbits/eslint-config-brainbits/commit/14611938cf8ccbce9e1812b7ef6b8ed912e085b7))





## 4.1.9 (2024-01-10)

**Note:** Version bump only for package react-test
4 changes: 2 additions & 2 deletions tests/react/package.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"name": "react-test",
"private": true,
"version": "4.1.9",
"version": "4.1.10",
"description": "Tests for eslint-config-brainbits-react",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"repository": "brainbits/eslint-config-brainbits",
"dependencies": {
"eslint-config-brainbits-react": "^4.1.9",
"eslint-config-brainbits-react": "^4.1.10",
"react": "^18.0.0"
}
}