Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmake dpp.lib(cluster.cpp.obj) : error LNK2019 #1007

Open
FabriicioMelo opened this issue Nov 18, 2023 · 12 comments
Open

xmake dpp.lib(cluster.cpp.obj) : error LNK2019 #1007

FabriicioMelo opened this issue Nov 18, 2023 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@FabriicioMelo
Copy link

Git commit reference:
ffa2653

Describe the bug:
When trying to install dpp through xmake, I receive this error, which does not allow me to start the project.

To Reproduce:
Steps to reproduce the behavior:

  1. Create a new xmake project
  2. Update the xmake.lua file by adding the dpp package, below the minimum configuration:
add_rules("mode.debug", "mode.release")

add_requires("dpp")

target("test-bot")
	set_kind("binary")
	add_files("src/*.cpp")

	add_packages("dpp")
  1. Then build it xmake build

Screenshots:
image

System Details:

  • OS: Windows 11 Pro 64 bits
  • Version: 22621.2715

Adicional Info:
I literally did what I was told on your website, here is the link: https://dpp.dev/10.0.28/install-xmake.html

@FabriicioMelo FabriicioMelo added the bug Something isn't working label Nov 18, 2023
@Mishura4 Mishura4 self-assigned this Nov 18, 2023
@Jaskowicz1
Copy link
Contributor

@Mishura4 This is related to #980. Is this because it's not ran inside visual studio?

@Mishura4
Copy link
Member

I'll investigate. In the meantime you can add DPP_BYPASS_VERSION_CHECKING to the list of defines in your project to work around this

@braindigitalis
Copy link
Contributor

you didn't link the windows sdk which contains the messageboxA function, this is required client side in the program which includes dpp.

@FabriicioMelo
Copy link
Author

@braindigitalis Thanks to you, I managed to compile. I found how to link to the sdk.
My xmake.lua file now looks like this:

add_rules("mode.debug", "mode.release")

add_requires("dpp")

target("test-bot")
    add_rules("win.sdk.application")

    set_kind("binary")
    add_files("src/*.cpp")

    add_packages("dpp")

You need to update this on your website.

@Mishura4
Copy link
Member

Please don't close this if it's not yet resolved on our end.

Thank you though for the solution, we'll look at this. There are potentially other solutions as well.

@Jaskowicz1
Copy link
Contributor

Jaskowicz1 commented Nov 22, 2023

Maybe we could simply change the solution to patch Scary->MyHead? If the windows api is found (check with #ifdef) then we do the message box, otherwise we could do a fallback and just send the error log via std::cout or something.

@Mishura4
Copy link
Member

I have ideas, I'll take a look soon
Very busy atm so probably next week

@Jaskowicz1
Copy link
Contributor

I have ideas, I'll take a look soon Very busy atm so probably next week

Okie dokie!

Copy link
Contributor

This issue has had no activity and is being marked as stale. If you still wish to continue with this issue please comment to reopen it.

@github-actions github-actions bot added the Stale label Jan 24, 2024
@Mishura4
Copy link
Member

i forgor

@github-actions github-actions bot removed the Stale label Jan 25, 2024
@braindigitalis
Copy link
Contributor

did you forgor mor?

@Jaskowicz1
Copy link
Contributor

@Mishura4 Did you forgor even mor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

4 participants