std::basic_string<uint8_t> is broken for LLVM-19

[DebuggingLife46]

Describe the bug
The uint8_t type is typedef'ed as unsigned char in glibc. However the support for unsigned char type has been removed from std::char_traits in libc++ according to https://reviews.llvm.org/D138307. This gives an "implicit instantiation of undefined template std::char_traits<unsigned char>" error, during build.

To Reproduce
Steps to reproduce the behavior:

1. Compile D++ using the latest libc++.

System Details:

• OS: Linux

Additional context
I would like to know what could be the proposed fix for this? I wouldn't mind sending the PR.

[braindigitalis]

what thing in dpp actually causes the warning, under what compiler and version?

[DebuggingLife46]

It's on this line

DPP/include/dpp/dispatcher.h

Line 2016 in 89b43ba

std::basic_string<uint8_t> audio_data = {};

. The compiler is Clang 19.

[braindigitalis]

I'm not sure this needs to be a string, perhaps a vector would suffice? it is important for it to be unsigned 8 bit wide elements though.

[DebuggingLife46]

Yeah, I agree.

[Jaskowicz1]

Any news on this?

[Mishura4]

Idk we just need to have someone pick this up

[Mishura4]

I can look into this next week