Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return str.replace(htmlEntitiesRegex, (match, dec : str.replace is not a function #54

Closed
DNeelanshi opened this issue Jun 26, 2023 · 4 comments

Comments

@DNeelanshi
Copy link

Null check is needed on str as its throwing error that str.replace is not a function

@oscarleonnogales
Copy link
Member

HI @DNeelanshi,

Great observation, I see what you mean. Please feel free to submit a PR with this change if you'd like to contribute!

For internal tracking, DTBTSDK-2818

@DNeelanshi
Copy link
Author

DNeelanshi commented Jul 17, 2023

Thank you @oscarleonnogales for your response , I will try to contribute by forking to fix this issue .

@DNeelanshi
Copy link
Author

please review PR #56

@oscarleonnogales
Copy link
Member

Thank you for starting the PR @DNeelanshi, I went ahead and did a few other changes along with your code and added you as a co-author for the final commit.

Closing this issue now as the PR has been merged and will be out in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants