Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove com.sun Dependency #95

Open
atkawa7 opened this issue Jan 2, 2021 · 10 comments
Open

Remove com.sun Dependency #95

atkawa7 opened this issue Jan 2, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@atkawa7
Copy link

atkawa7 commented Jan 2, 2021

No description provided.

@atkawa7 atkawa7 changed the title Remove com.sun Depedency Remove com.sun Dependency Jan 2, 2021
@catchex
Copy link
Member

catchex commented Jan 2, 2021

Hi, in Java 1.8, tools of package 'com.sun' is required, the ObjectiveSQL minimum supported version is 1.8

@atkawa7
Copy link
Author

atkawa7 commented Jan 2, 2021

You can use the alternative javax.lang.model* and javax.tools.* classes instead of calling com.sun packages

@catchex
Copy link
Member

catchex commented Jan 2, 2021

What you said should be right, I should given bytecode version while project deploy. But Java 8 users may have problems

@catchex
Copy link
Member

catchex commented Jan 2, 2021

I should verify it carefully and release a new version, thanks for you reply.

@atkawa7
Copy link
Author

atkawa7 commented Jan 2, 2021

On a side note I was looking at another library that does similar things it seems they do not depend on tools.

https://github.com/google/error-prone/blob/master/check_api/pom.xml
https://github.com/google/error-prone/blob/master/check_api/src/main/java/com/google/errorprone/util/ASTHelpers.java

-        <dependency>
-            <groupId>com.sun</groupId>
-            <artifactId>tools</artifactId>
-            <version>1.0</version>
-            <scope>system</scope>
-            <systemPath>${java.home}/../lib/tools.jar</systemPath>
-            <optional>true</optional>
-        </dependency>

@atkawa7
Copy link
Author

atkawa7 commented Jan 2, 2021

Is it possible to see the code that is generated when you inject it via annotation processor?

@catchex
Copy link
Member

catchex commented Jan 2, 2021

That's it! because JDK 1.8 is the base version in my project, I can understand your suggestion, this should be a mistake of mine

@catchex catchex self-assigned this Jan 2, 2021
@catchex catchex added the enhancement New feature or request label Jan 2, 2021
@atkawa7
Copy link
Author

atkawa7 commented Jan 6, 2021

@catchex Did you win?

@catchex
Copy link
Member

catchex commented Jan 6, 2021

I had get your suggestion, sorry, codes have not been submitted

@atkawa7
Copy link
Author

atkawa7 commented Nov 19, 2021

@catchex ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants