Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate options always-on kill switch #23579

Merged
merged 3 commits into from May 13, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented May 10, 2024

Resolves brave/brave-browser#38238

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Always on & kill switch should have separate options with correct text details as described in
https://www.figma.com/file/J4LKBMftiWhqromRWfUQLG/VPN-design?type=design&node-id=113%3A12449&mode=design&t=ydOR66fQB0qeJv5X-1

@deeppandya deeppandya requested a review from a team as a code owner May 10, 2024 19:50
@deeppandya deeppandya requested a review from tapanmodh May 10, 2024 19:52
@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels May 10, 2024
@deeppandya deeppandya added this to the 1.68.x - Nightly milestone May 10, 2024
@deeppandya deeppandya force-pushed the seperate_options_alwayson_kill_switch branch from d2c5b96 to 0d71d85 Compare May 13, 2024 13:44
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya merged commit 5725372 into master May 13, 2024
18 checks passed
@deeppandya deeppandya deleted the seperate_options_alwayson_kill_switch branch May 13, 2024 16:28
brave-builds added a commit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
3 participants