You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that one union type in my project is not getting expanded as I would've expected. It is a union type from a 3rd party dependency that is installed as a node module. I am importing this type like this: import { Placement } from '@floating-ui/dom';
Then in my lit component I have a property like this: @property() public placement?: Placement;
What ends up in my custom-elements-manifest.json looks like this:
{
"text": "Placement | undefined"
}
I would have expected this type to be expanded like local union types.
The text was updated successfully, but these errors were encountered:
I quickly checked out the code and saw, that getResolvedImportPath is currently using path.resolve which is not able to resolve node_module imports. Other than that, it should probably be possible IMO. Do you know if there is any other issue I didn't see, preventing this? Maybe if I can find time in the coming days I could have a look at it.
I believe it was initially added but removed due to performance issues. That was early on and the plugin has changed significantly since then, so it may no longer be an issue.
I noticed that one union type in my project is not getting expanded as I would've expected. It is a union type from a 3rd party dependency that is installed as a node module. I am importing this type like this:
import { Placement } from '@floating-ui/dom';
Then in my lit component I have a property like this:
@property() public placement?: Placement;
What ends up in my
custom-elements-manifest.json
looks like this:I would have expected this type to be expanded like local union types.
The text was updated successfully, but these errors were encountered: