Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serverless.yml file is deleted when package is uninstalled #55

Open
driskell opened this issue Jan 13, 2022 · 3 comments
Open

serverless.yml file is deleted when package is uninstalled #55

driskell opened this issue Jan 13, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@driskell
Copy link

Hello.

When removing the package it seems unexpected to me for serverless.yml to be removed and any active changes lost, as it's usually created by bref init so I didn't expect something else to take control of it.

I wonder if perhaps it shouldn't be bundled in the recipe?

@mnapoli
Copy link
Member

mnapoli commented Jan 16, 2022

Hi! This is very surprising indeed, that's not intended to behave that way.

Could it be because serverless.yml is created via a recipe? 🤔

@ker0x since you created the recipe in symfony/recipes-contrib#1129 do you have any idea about that?

@mnapoli mnapoli added the bug Something isn't working label Jan 16, 2022
@t-richard
Copy link
Member

I think the is the intended behaviour from a Flex perspective.

AFAIK, everything created on composer require is deleted on composer remove.

I don't think this is configurable.

The paved way for installing this package is to go througth the Symfony part of Bref docs which doesn't involve a bref init.

I'm not sure what we can do about this exept contribute a new feature to Flex or remove the recipe.

@mnapoli
Copy link
Member

mnapoli commented Jan 17, 2022

Oh… yeah that sucks.

I'm afraid the best way to go would be to give up on Flex recipes and create our own bin/console bre:init command 🤔 (or similar). That would also solve the problem of the serverless.yml template being stored outside of this repository (which means we have no control over it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants