Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ApproxEq for all primitives #6

Open
3 of 5 tasks
WaDelma opened this issue Aug 19, 2016 · 6 comments
Open
3 of 5 tasks

Implement ApproxEq for all primitives #6

WaDelma opened this issue Aug 19, 2016 · 6 comments

Comments

@WaDelma
Copy link

WaDelma commented Aug 19, 2016

Currently only f32 and f64 are implemented.

  • (T, ..)
  • [T]
  • RefCell<T>
  • Cell<T>
  • [T; n] (up to 32)
@brendanzab
Copy link
Owner

We should write down a list of these!

@brendanzab
Copy link
Owner

Added some to the list!

@sebcrozet
Copy link
Collaborator

I think @WaDelma was referring to other numeric primitive types like u32, i32, etc.
Though I'm not sure what ulps would mean for them so it might not be worth it.

@brendanzab
Copy link
Owner

Hmm, yeah. Is this a problem with the API? What does approx mean for integers?

@milibopp
Copy link

milibopp commented Sep 9, 2017

What about [T; n]? Could we add it to the list? Maybe up to n = 32 like it's done in std.

@Darkdragon84
Copy link

Hey! What's the status on tuples? I would find that very useful for lots and lots of my unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants