Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a 1.0 version #70

Open
obsgolem opened this issue Sep 2, 2021 · 3 comments
Open

Release a 1.0 version #70

obsgolem opened this issue Sep 2, 2021 · 3 comments

Comments

@obsgolem
Copy link

obsgolem commented Sep 2, 2021

This library appears to be the de-facto standard for approximate comparisons. Downstreams include ndarray and nalgebra. I just ran into an issue where ndarray is using an older version tied to an older version of num-complex. If you aren't planning on making breaking changes then it would be nice if you could bump to a 1.0 version so that feature additions don't require upstreams to bump their versions.

@sebcrozet
Copy link
Collaborator

sebcrozet commented Sep 2, 2021

Bumping approx to a 1.0 version won’t solve the num-complex problem. Using a new version of num-complex will still require a major version bump of approx, even if no breaking change is done on approx itself.

@obsgolem
Copy link
Author

obsgolem commented Sep 3, 2021

As you can see I actually opened a similar issue with num-complex for that reason. That being said I think there is still value in this crate considering doing it as well.

@Jules-Bertholet
Copy link

Another way to limit future breakage could be to use the semver trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants