Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows PATH #14

Open
brettcannon opened this issue Jun 27, 2020 · 7 comments
Open

Support Windows PATH #14

brettcannon opened this issue Jun 27, 2020 · 7 comments

Comments

@brettcannon
Copy link
Owner

Should work, but need to start testing on Windows

@messense
Copy link

It doesn't compile on Windows due to the use of nix crate.

@brettcannon
Copy link
Owner Author

Correct, no attempt has been made at Windows support yet.

@cnpryer
Copy link

cnpryer commented Jan 26, 2023

Maybe I'm misunderstanding, but it seems like the nix dependency is only used for the py binary. The library could still implement support for PATH, right?

@brettcannon
Copy link
Owner Author

Maybe I'm misunderstanding, but it seems like the nix dependency is only used for the py binary. The library could still implement support for PATH, right?

There isn't really a separate library yet, but there are plans to create one. In that instance there shouldn't be an issue with Windows support. I do still hope to eventually make the binary work with Windows as well.

@cnpryer
Copy link

cnpryer commented Jan 27, 2023

Cool! Are you open to PRs to help support Windows even if it's just library changes? I looked into options for the py changes, but I couldn't find anything low-hanging that'd replace the process for you instead of just spawning a second one.

Referring to #2 (comment) specifically.

@brettcannon
Copy link
Owner Author

Are you open to PRs to help support Windows even if it's just library changes?

Not at this moment as I would worry it wouldn't get tested appropriately until it is a separate crate. But once the separate crate exists I will definitely take a PR!

I couldn't find anything low-hanging that'd replace the process for you instead of just spawning a second one.

I honestly don't think such an option exists on Windows, so it will just require launching a second process. I haven't delved into that because if you look at https://github.com/python/cpython/blob/main/PC/launcher2.c you will notice it isn't a simple "launch another process" thing.

@cnpryer
Copy link

cnpryer commented Mar 14, 2023

FWIW it looks like cargo tries to do this with a Ctrl-C signal
https://github.com/rust-lang/cargo/blob/4a3c588b1f0a8e2dc8dd8789dbf3b6a71b02ed49/crates/cargo-util/src/process_builder.rs#L259-L276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants