Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a replacement for stderrlog #211

Open
brettcannon opened this issue Jun 17, 2022 · 6 comments
Open

Find a replacement for stderrlog #211

brettcannon opened this issue Jun 17, 2022 · 6 comments
Labels
impact-bugfix Fixes a bug

Comments

@brettcannon
Copy link
Owner

stderrlog has not been updated in a year and there are minor edge cases in outdated dependencies that could cause a segfault. Better safe than sorry, so probably best to replace the crate with something that's being updated regularly.
@brettcannon brettcannon added the impact-bugfix Fixes a bug label Jun 17, 2022
brettcannon added a commit that referenced this issue Jun 17, 2022
@brettcannon
Don't run cargo audit until #211 is fixed
321d1d4
@brettcannon
Copy link
Owner Author

#216 just updated stderrlog, so hopefully that takes care of this concern. 🤞

@brettcannon
Copy link
Owner Author

Nope ☹️ https://github.com/brettcannon/python-launcher/runs/7350209622?check_suite_focus=true#step:6:20

@brettcannon
Copy link
Owner Author

https://docs.rs/tracing/latest/tracing/index.html

@carltongibson
Copy link

This PR on stderrlog looked promising (in that it addressed the advisory issue) cardoe/stderrlog-rs#46

@carltongibson carltongibson mentioned this issue Nov 4, 2022
Merged
@brettcannon
Copy link
Owner Author

Didn't fix it: https://github.com/brettcannon/python-launcher/actions/runs/3544379737/jobs/5951595747#step:6:18

@brettcannon
Copy link
Owner Author

Another possibility: https://crates.io/crates/env_logger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact-bugfix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @carltongibson