Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change native export method #97

Open
avaly opened this issue Oct 29, 2020 · 1 comment
Open

Change native export method #97

avaly opened this issue Oct 29, 2020 · 1 comment

Comments

@avaly
Copy link

avaly commented Oct 29, 2020

Starting with node.js v14.13.0 CommonJS modules are parsed to detect their exports bindings. In this case pg is triggering the lazy loading of the pg-native dependency.

Please consider exporting the native feature in another compatible way.

See: nodejs/node#35859

@charmander
Copy link
Collaborator

The error message will be fixed by brianc/node-postgres#2372. I don’t think skipping loading the module tree entirely will happen in 8.x; it’s hard to make backwards-compatible, for not much benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants