PHPStan interface mismatch

[calebdw]

Hello,

Running PHPStan on my project yields the following error:

Carbon: 2.71.0
PHPStan 1.10.43
Thanks!

[buffcode]

In the reversal commit phpstan/phpstan-src@d0c0938 of phpstan/phpstan-src@ad6703d the nullable types were removed.

before:

BuiltinMethodReflection::getReflection(): ?ReflectionMethod

after:

BuiltinMethodReflection::getReflection(): ReflectionMethod

Not sure if this was intended.

[kylekatarnls]

Because extending the macro class was the only way to support properly Carbon macro, even some patches in PHPStan updates can be breaking changes it and it's hard to be compatible with new version without dropping the previous versions (which if we proceed to fast also raises complains).

I'm open to pull-request that would fix this while still supporting PHPStan from 1.10.20 to 1.10.43.

[kylekatarnls]

Side note to people adding comments/reactions not helping fixing the issue.

As a open-source provided to you for free, there is no obligation for anyone to immediately jump and fix something. Mostly if the bug was introduced by another library, and mostly if it's not a core feature.

Carbon core feature is enhancing DateTime PHP class with human-friendly methods. The support of PHPStan analysis is a nice-to-have side-feature.

All you have via OSS out of the box is quite a miracle, but it's still not a reason to expect everything you need to get done by someone else. If you want it, you can get your hands dirty and craft the pull-request.

[buffcode]

See comment: phpstan/phpstan-src@d0c0938#r133136268

Hi, please note that I reverted this as a courtesy to nesbot/carbon package. You shouldn't be interested in this interface because it's not part of the backward compatibility promise: https://phpstan.org/developing-extensions/backward-compatibility-promise

It will be removed in the future.

Please open a discussion with your use-case and I'll guide you what to replace the usage with.

[kylekatarnls]

Hello, I won't personally invest time in this. If this get removed with no alternative and no one proposed another way to support analysis for the macro methods, then we'll just remove the PHPStan extension from Carbon, and we'll delegate that to whoever is interested in building a library for that.

I have to be a bit picky with what we support because every piece asked/added even when it's done by another volunteer contributor typically ends with maintenance burden on core team.

[buffcode]

@kylekatarnls Is it viable to extract this functionality into a separate package? This way it won't affect the core package and maintenance could (or could not) progress separately.

I'm not too much into the PHPStan internals and don't know, if this must reside in the nesbot/carbon package or could be supplied by a third-party package.

[kylekatarnls]

Yes actually that's the path I should have taken from the beginning because having it inside is adding constraint on version supported. With an external package, it could have more flexibility and even fix support for previously released version of both Carbon and PHPStan.

[calebdw]

Closing as fixed (temporarily) via phpstan/phpstan-src#2762