fix(Rounding): apply rounding changes to result before applying unit #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will run unit tests but I suspect this will break other cases. |
|
I was thinking the same, but everything still works as expected. Looking at the code coverage report, the re-run in case of overflow part isn't even needed anymore when doing this, so I'll create a commit to remove that part. If you have any idea on how to better test this let me know. |
|
🤔 This should be fine, the code was changed to fix #2268 and a unit test ensure this fix didn't regress. |
kylekatarnls
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a problem that looked a bit like #2268.
When rounding down to quarters, the month overflows when a date is after a possible date of the rounded month. This PR causes the changes to be applied before the main unit is changed, so the day is set before the month.
You can see an example in the tests. When rounding down months by a precision of 3, the 31st of may now becomes the 1st of april, instead of the 1st of may.