Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong license identification on crates.io breaks guix importer #246

Open
Kreyren opened this issue Nov 16, 2021 · 3 comments
Open

Wrong license identification on crates.io breaks guix importer #246

Kreyren opened this issue Nov 16, 2021 · 3 comments

Comments

@Kreyren
Copy link

Kreyren commented Nov 16, 2021

Guix importer generates an import as:

kreyren@leonid ~$ guix import crate webpki
following redirection to `https://static.crates.io/crates/webpki/webpki-0.22.0.crate'...
(define-public rust-webpki-0.22
  (package
    (name "rust-webpki")
    (version "0.22.0")
    (source
      (origin
        (method url-fetch)
        (uri (crate-uri "webpki" version))
        (file-name (string-append name "-" version ".tar.gz"))
        (sha256
          (base32 "1gd1gxip5kgdwmrvhj5gjxij2mgg2mavq1ych4q1h272ja0xg5gh"))))
    (build-system cargo-build-system)
    (arguments
      `(#:cargo-inputs
        (("rust-ring" ,rust-ring-0.16) ("rust-untrusted" ,rust-untrusted-0.7))
        #:cargo-development-inputs
        (("rust-base64" ,rust-base64-0.9))))
    (home-page "https://github.com/briansmith/webpki")
    (synopsis "Web PKI X.509 Certificate Verification.")
    (description "Web PKI X.509 Certificate Verification.")
    (license unknown-license!)))

Note the (license unknown-license!) which breaks the build and needs to be manually fixed on (license (list lisense:isc license:bsd-3)

Please fix the license metadata on crates.io to not be non-standard when the project is isc.

@briansmith
Copy link
Owner

briansmith commented Nov 16, 2021

Some of the files in the crate are not ISC licensed. In particular some of the test files. Unfortunately, Cargo doesn't seem to have a way of distinguishing the license of the test stuff from the license of the library.

@briansmith
Copy link
Owner

Note the (license unknown-license!) which breaks the build and needs to be manually fixed on (license (list lisense:isc license:bsd-3)

I overlooked this part of the suggestion. This seems like a fine change to make to me.

@Kreyren
Copy link
Author

Kreyren commented Dec 11, 2021

Sorry if i made that unclear, basically the suggestion is to use recognizable license on crates.io for automation purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants