Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goldpage does not work on windows #21

Open
estyrke opened this issue Apr 29, 2020 · 10 comments
Open

Goldpage does not work on windows #21

estyrke opened this issue Apr 29, 2020 · 10 comments
Labels
enhancement New feature or request

Comments

@estyrke
Copy link

estyrke commented Apr 29, 2020

When running goldpage build (or goldpage dev) on windows, an internal error occurs (unfortunately I don't have a windows box to try on now, but the error is very terse anyway). It seems related to the assumption that paths are separated by forward slashes, which is not the case on windows.

@brillout
Copy link
Owner

brillout commented May 1, 2020

That's possible. I don't have a windows box right now but I'll have a look at it later.

@brillout
Copy link
Owner

brillout commented Oct 1, 2020

Goldpage doesn't support Windows for now. Comment this ticket if you want windows support.

@brillout brillout added the enhancement New feature or request label Oct 1, 2020
@littleninja
Copy link

littleninja commented Jan 12, 2021

I'm doing a bit of research and discovered Goldpage, love its focus on do-one-thing-do-it-well! Knowing my team works primarily on Windows (I'm on MacOS), we might give Goldpage a spin with WSL but this would be a non-starter for us.

Assuming this issue may one day be closed as "Won't Fix", it'd be great if there was a note in the README with platform support.

It seems related to the assumption that paths are separated by forward slashes, which is not the case on windows.

This tickles my curiosity but I'm not on Windows. I wonder if path.join() or cross-env (now in maintenance, alternatives include env-cmd or @naholyr/cross-env) could help.

@brillout
Copy link
Owner

Hi @littleninja !

I will have another look and tentatively write a patch.

@brillout
Copy link
Owner

I'll write a patch tentivally next week. In the meantime, WSL should work.

@brillout
Copy link
Owner

@littleninja Still interested? I've capacity today to write the patch.

@littleninja
Copy link

Sorry for the delay, I hope my comment didn't come across in a way that shifted priorities. There's no urgency on my part. 😔

@brillout
Copy link
Owner

No worries.

There's no urgency

You may wanna wait on #24 then. It's going to be lovely.

If you don't mind me asking; what exactly are your plans with Goldpage? We can discuss in depth about whether Goldpage is/will be a good fit for you, and it's insightful for me to talk about my users' use cases.

@brillout
Copy link
Owner

@brillout
Copy link
Owner

@littleninja https://github.com/brillout/vite-plugin-ssr is pretty much done and I published a beta. I'd be curious to know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants