Skip to content

Commit 9b55367

Browse files
committedAug 24, 2023
fix: improve similar known config hint
1 parent c0979f2 commit 9b55367

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed
 

‎vite-plugin-ssr/node/plugin/plugins/importUserCode/v1-design/getVikeConfig.ts

+10-7
Original file line numberDiff line numberDiff line change
@@ -1213,23 +1213,26 @@ function handleUserFileError(err: unknown, isDev: boolean) {
12131213

12141214
function isGlobalConfig(configName: string): configName is ConfigNameGlobal {
12151215
if (configName === 'prerender') return false
1216-
const configNamesGlobal = Object.keys(configDefinitionsBuiltInGlobal)
1216+
const configNamesGlobal = getConfigNamesGlobal()
12171217
return arrayIncludes(configNamesGlobal, configName)
12181218
}
1219+
function getConfigNamesGlobal() {
1220+
return Object.keys(configDefinitionsBuiltInGlobal)
1221+
}
12191222

1220-
function assertConfigExists(configName: string, configsDefined: string[], definedByFile: string) {
1221-
if (isGlobalConfig(configName)) return
1222-
if (configsDefined.includes(configName)) return
1223-
handleUnknownConfig(configName, configsDefined, definedByFile)
1223+
function assertConfigExists(configName: string, configNamesRelevant: string[], definedByFile: string) {
1224+
const configNames = [...configNamesRelevant, ...getConfigNamesGlobal()]
1225+
if (configNames.includes(configName)) return
1226+
handleUnknownConfig(configName, configNames, definedByFile)
12241227
assert(false)
12251228
}
1226-
function handleUnknownConfig(configName: string, configsDefined: string[], definedByFile: string) {
1229+
function handleUnknownConfig(configName: string, configNames: string[], definedByFile: string) {
12271230
let errMsg = `${definedByFile} defines an unknown config ${pc.bold(configName)}`
12281231
let configNameSimilar: string | null = null
12291232
if (configName === 'page') {
12301233
configNameSimilar = 'Page'
12311234
} else {
1232-
configNameSimilar = getMostSimilar(configName, configsDefined)
1235+
configNameSimilar = getMostSimilar(configName, configNames)
12331236
}
12341237
if (configNameSimilar) {
12351238
assert(configNameSimilar !== configName)

0 commit comments

Comments
 (0)
Please sign in to comment.