Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsDelivr broken, package size too large #1016

Open
jurchiks opened this issue Jan 16, 2023 · 3 comments
Open

jsDelivr broken, package size too large #1016

jurchiks opened this issue Jan 16, 2023 · 3 comments
Labels
status:in_progress Issue that is being worked on right now type:bug An unexpected problem or unintended behavior

Comments

@jurchiks
Copy link

jurchiks commented Jan 16, 2023

https://www.jsdelivr.com/package/npm/britecharts
image
The result is that we can't use the CDN anymore as the assets return 403 Forbidden and are not downloaded, thus breaking the content.

I can see that there is no tag named 2.18.2 in this repo at all, so I have to wonder where that came from.

@jurchiks jurchiks added the type:bug An unexpected problem or unintended behavior label Jan 16, 2023
@Golodhros
Copy link
Collaborator

Hi @jurchiks, thanks for opening this issue!

Yeah, there was this "ghost" release that got in there but I don't know how to get rid of it! I still can't...

Maybe I should deploy a 2.18.2 for true and see if that fixes it.

BTW, I was wondering if I should deprecate all the CDN setup for version 3, but it seems there are users for it.

@Golodhros Golodhros added the status:in_progress Issue that is being worked on right now label Jan 17, 2023
@jurchiks
Copy link
Author

jurchiks commented Jan 17, 2023

I presume you tagged a commit with 2.18.2 but then hard reset + force pushed to delete that commit.
If not, then you or someone else could have deleted the tag itself: https://devconnected.com/how-to-delete-local-and-remote-tags-on-git/
Either way, pushing a different commit with that tag might not work because it's possible the CDN would just see it as "I already have this tag", so I would recommend pushing 2.18.2 (for continuity) AND 2.18.3 (to override).

All of this presumes, of course, that it would fix the oversized package in the first place.

@Golodhros
Copy link
Collaborator

Makes sense, I will do that.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:in_progress Issue that is being worked on right now type:bug An unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants