Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable "no-undef" eslint rule for type-check #77

Closed
davidhorak opened this issue Sep 2, 2020 · 0 comments · Fixed by #79
Closed

Re-enable "no-undef" eslint rule for type-check #77

davidhorak opened this issue Sep 2, 2020 · 0 comments · Fixed by #79
Labels
c-maintenance A maintenance task or todo that preserves value.

Comments

@davidhorak
Copy link
Contributor

Description

  • Current version of eslint triggers false errors for User Defined Type Guards:
export function isDate (value: unknown): value is Date {
  return value instanceof Date
}
// error  'value' is not defined  no-undef

When fixed, re-enable the no-undef rule:

illogical/src/common/type-check.ts

Line 1 in c48a6c5

/* eslint-disable no-undef */

@davidhorak davidhorak added the c-maintenance A maintenance task or todo that preserves value. label Sep 2, 2020
@davidhorak davidhorak mentioned this issue Sep 17, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c-maintenance A maintenance task or todo that preserves value.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the "User Defined Type Guards" false positive eslint error briza-insurance/illogical
1 participant
@davidhorak