Re-enable "no-undef" eslint rule for type-check

[davidhorak]

Description

• Current version of eslint triggers false errors for User Defined Type Guards:

export function isDate (value: unknown): value is Date {
  return value instanceof Date
}
// error  'value' is not defined  no-undef

• Reported bug: [no-undef] No-undef error on user-defined Typescript type guards typescript-eslint/typescript-eslint#2462

When fixed, re-enable the no-undef rule:

wegood/src/common/type-check.ts

Line 1 in 9f36ca2

/* eslint-disable no-undef */

[rthreei]

I see. Should that be value: any instead?

[davidhorak]

I see. Should that be value: any instead?

It is this bit : value is Date , the https://www.typescriptlang.org/docs/handbook/advanced-types.html#user-defined-type-guards which triggers the erorr

[davidhorak]

I see. Should that be value: any instead?

It is this bit : value is Date , the https://www.typescriptlang.org/docs/handbook/advanced-types.html#user-defined-type-guards which triggers the erorr

the eslint sees the "value" variable as "not defined" regardless its type

[rthreei]

Interesting. Why not disable that lint rule for that line specifically then?

[davidhorak]

Interesting. Why not disable that lint rule for that line specifically then?

Great point, 9f36ca2