Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing AQS and other parameters in google url searches #726

Open
uazo opened this issue Sep 4, 2020 · 5 comments · May be fixed by #731
Open

Consider removing AQS and other parameters in google url searches #726

uazo opened this issue Sep 4, 2020 · 5 comments · May be fixed by #731

Comments

@uazo
Copy link
Collaborator

uazo commented Sep 4, 2020

Is your feature request related to privacy?

yes

Is there a patch available for this feature somewhere?

I don't know

Describe the solution you would like

remove "The optional assisted query stats, aka AQS, used for logging purposes."
I found in code

    // The optional assisted query stats, aka AQS, used for logging purposes.
    // This string contains impressions of all autocomplete matches shown
    // at the query submission time.  For privacy reasons, we require the
    // search provider to support HTTPS protocol in order to receive the AQS
    // param.
    // For more details, see http://goto.google.com/binary-clients-logging .
    std::string assisted_query_stats;

now the search url is composed like this (looking for"fq")
https://www.google.com/search?q=fq&oq=fg&aqs=chrome..69i57.724j0j4&sourceid=chrome-mobile&ie=UTF-8

QUERY
q=fq

GOOGLE_ORIGINAL_QUERY_FOR_SUGGESTION
oq=fg

GOOGLE_ASSISTED_QUERY_STATS
aqs=chrome..69i57.724j0j4

with this contents:

sourceid=chrome-mobile
ie=UTF-8

Describe alternatives you have considered

  1. remove that codes from components/search_engines/prepopulated_engines.json

  2. check the use and remove all specific google code from
    https://source.chromium.org/chromium/chromium/src/+/master:components/search_engines/template_url.cc;l=650
    and
    https://source.chromium.org/chromium/chromium/src/+/master:components/search_engines/template_url.cc;l=931
@csagan5
Copy link
Contributor

csagan5 commented Sep 4, 2020

There is already a patch that prevents this, ungoogled-chromium: Disable Google host detection.

@csagan5 csagan5 closed this as completed Sep 4, 2020
@uazo
Copy link
Collaborator Author

uazo commented Sep 5, 2020

I don't understand, that patch doesn't do what I say.
try it yourself with the current version, obviously don't select "Google in English" among the search engines.

Other possible alternatives:

  • Remove hl=en from googleen
  • Propose a better ui for search engines settings (manual editing)

@csagan5
Copy link
Contributor

csagan5 commented Sep 5, 2020

@uazo then I suggest to remove more replacements, not just those you mentioned. They are almost all good candidates for removal (field trial, referral ids, rlz, cursor position etc).

I would leave prepopulated_engines.json untouched but make it so the whole {google:assistedQueryStats} gets replaced with empty string `` (should be possible).

Do you want to submit a patch for this?

@csagan5 csagan5 reopened this Sep 5, 2020
@uazo
Copy link
Collaborator Author

uazo commented Sep 5, 2020

Do you want to submit a patch for this?

Yes, of course.

@uazo uazo linked a pull request Sep 6, 2020 that will close this issue
Open
@csagan5 csagan5 mentioned this issue Jun 21, 2021
Closed
@S-Kamran
Copy link

GOOGLE_ASSISTED_QUERY_STATS
aqs=chrome..69i57.724j0j4

what is this?
every time no is change
how to prevent from this is this malicious ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove AQS and some other parameters from search URLs uazo/cromite
3 participants
@uazo @csagan5 @S-Kamran