Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mix of aspect ratios in gallery #526

Open
bibekthapa007 opened this issue Sep 1, 2020 · 3 comments
Open

Support mix of aspect ratios in gallery #526

bibekthapa007 opened this issue Sep 1, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@bibekthapa007
Copy link

bibekthapa007 commented Sep 1, 2020

Responsive of the image and gallery is missing in it such image of different width, no of images in row and gallery.
It will nice if there was props to control the image and gallery property

Feature missing can be found here https://github.com/benhowell/react-grid-gallery

@bibekthapa007 bibekthapa007 changed the title Feature missing for the gallery Feature missing for the gallery and image Sep 1, 2020
@browniebroke
Copy link
Owner

Can you please elaborate on what you mean by "responsive" exactly? The images are being resized when the browser window change width currently, so one might consider them responsive already?

Looking at the library you linked to, I assume you mean a justified layout containing a mix on different aspect ratios like below as opposed to the squares we currently use, but would be nice to get this clarified.

image

@bibekthapa007
Copy link
Author

I am talking about being able to use different aspect ratios image.
Croping image in different aspect ratios make it looks irresponsive.
And add the no. of image displayed in row and all the gallery according to the width or min-width, min-height property to the image. and gallery.

@browniebroke browniebroke added the enhancement New feature or request label Sep 1, 2020
@browniebroke browniebroke changed the title Feature missing for the gallery and image Support mix of aspect ratios in gallery Sep 1, 2020
@julietrubin
Copy link

I'd really love this feature too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants