Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test block with no tests, and test counts #483

Open
shriram opened this issue Sep 17, 2023 · 1 comment
Open

test block with no tests, and test counts #483

shriram opened this issue Sep 17, 2023 · 1 comment

Comments

@shriram
Copy link
Member

shriram commented Sep 17, 2023

I feel like we've been over this before, but I can't find the PR right now…

It seems really confusing to use a green background for "no tests" blocks. Students see

image

and don't read the fine-print and think a bunch of top-level function calls (with no testing operators) is a valid test suite.

Didn't we discuss changing the color of such blocks? If anything, it should be a "negative" color, because more likely than not this is an error (and if it's intentional, the programmer will know — but even then, they may later forget to change the block to contain tests again, so the reminder can't hurt).

I realize there's a fine line here and green for a single test could still obscure similar errors. We should still handle this special case differently because it would be instructive for students. But perhaps instead of a small number amidst a lot of text

image

we should have a stronger visual indicator of how many tests passed [like this, but even more salient]:

image
@schanzer
Copy link
Contributor

I'm a big fan of stoplight colors. We already use green for pass and red for fail. Perhaps we should use yellow for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants