Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts implementing this package for mark-ring #71

Open
lordnik22 opened this issue Nov 9, 2022 · 1 comment
Open

Thoughts implementing this package for mark-ring #71

lordnik22 opened this issue Nov 9, 2022 · 1 comment

Comments

@lordnik22
Copy link

Hi

I'm using this package since some time and really like it. Thanks!

I had an idea that I liked to implement and wanted to ask for some advice, hints and tips.

I want to use the same concept but instead of the kill-ring, it should be for the mark-ring.

How much tweaking would be needed to use this for the mark-ring?

May it be optimal to abstract it in a way to work with any "ring"-datastructure?

@T-J-Teru
Copy link
Member

The mark-ring feels pretty different to the kill-ring - with the kill-ring our location in the original buffer is fixed and we're offering different things to insert, with the mark-ring we'd be offering different locations in the original buffer, so as you browse the ring you'll be changing the original buffer's location.

That said, I can see how there are definite similarities between the two, and having an underlying library that allows for managing popping up the browse buffer, and switching between entries could be a good thing.

I think if I was approaching the task I would take the existing code and just change it up to get the browse-mark-ring behaviour that I wanted, then, I'd go back and look to see what could actually be shared between the two packages, pull that code out and try to make it into a "browse-ring" library that could be shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants