Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings from Emacs 29.1 upon loading browse-kill-ring #72

Open
tomdavey opened this issue Sep 29, 2023 · 2 comments
Open

Warnings from Emacs 29.1 upon loading browse-kill-ring #72

tomdavey opened this issue Sep 29, 2023 · 2 comments

Comments

@tomdavey
Copy link

FYI, here's what's appearing in the Messages buffer after loading the current version (20220410.1509) of browse-kill-ring :

.emacs.d/load-path-subdirs/td-esdf/td-startup-lisp/Elpa/browse-kill-ring-20220410.1509/browse-kill-ring.el: Warning: Case 'insert will match `quote'.  If that's intended, write (insert quote) instead.  Otherwise, don't quote `insert'.
.emacs.d/load-path-subdirs/td-esdf/td-startup-lisp/Elpa/browse-kill-ring-20220410.1509/browse-kill-ring.el: Warning: Case 'append will match `quote'.  If that's intended, write (append quote) instead.  Otherwise, don't quote `append'.
.emacs.d/load-path-subdirs/td-esdf/td-startup-lisp/Elpa/browse-kill-ring-20220410.1509/browse-kill-ring.el: Warning: Case 'prepend will match `quote'.  If that's intended, write (prepend quote) instead.  Otherwise, don't quote `prepend'.
.emacs.d/load-path-subdirs/td-esdf/td-startup-lisp/Elpa/browse-kill-ring-20220410.1509/browse-kill-ring.el: Warning: Case 'move will match `quote'.  If that's intended, write (move quote) instead.  Otherwise, don't quote `move'.
.emacs.d/load-path-subdirs/td-esdf/td-startup-lisp/Elpa/browse-kill-ring-20220410.1509/browse-kill-ring.el: Warning: Case 'delete will match `quote'.  If that's intended, write (delete quote) instead.  Otherwise, don't quote `delete'.
.emacs.d/load-path-subdirs/td-esdf/td-startup-lisp/Elpa/browse-kill-ring-20220410.1509/browse-kill-ring.el: Warning: Case 'solid will match `quote'.  If that's intended, write (solid quote) instead.  Otherwise, don't quote `solid'.
@To1ne
Copy link
Member

To1ne commented Nov 3, 2023

I'm no longer actively maintaining this package. I'm happy to hand over maintainership, or review a PR to fix this.

T-J-Teru added a commit that referenced this issue Nov 4, 2023
@T-J-Teru
Fix quoted cl-case keys, which caused warnings to be emitted
03cc18c 
We were incorrectly quoting the keys in a couple of our cl-case uses.
This was causing some warnings on at least Emacs 29.1.  Fixed in this
commit by removing the quoting.  Tested on Emacs 29.1 and 26.3, and
everything still seems to be working.

This resolves issue #72.
@T-J-Teru
Copy link
Member

T-J-Teru commented Nov 4, 2023

I pushed commit 03cc18c that I think should resolve this issue. Let me know if you are still seeing these warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@To1ne @T-J-Teru @tomdavey