-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace jsonstream with JSONStream #1251
Comments
I would not depend on "npm only checks the name validation in the client". That may change and cause dominictarr/JSONStream#68 all over again. I'm not sure the solution, but it would more than likely involve the lower case name (as it conforms to the [confused] opinions npm has about package names). |
@TheSharpieOne I think it makes sense to go back to "JSONStream" as a semver patch (just like it was semver patch to go to "jsonstream"), and leave any changes in case to a semver major release. |
@TheSharpieOne when npm introduced the lower case rule it did allow updates to legacy upper case modules (for better or worse) they broke that, but they have promised to fix it, so i think it is reasonable. there are currently only 8 modules that use jsonstream but > 280 that use JSONStream directly. So it's gonna be much easier to get those 8 modules to change than those 280! |
@dominictarr I see. As long as npm allows for support of legacy uppercase modules going forward (fixing that bug). I would rather see npm know the difference between upper and lowercase (which may be OS related, but they can work around that). |
It doesn't sound like anything is going to happen in that department. You way want to see this issue @zertosh pointed me to: npm/npm#7933 |
Ok it's all published now with JSONStream as browserify@10.1.3, browser-pack@4.0.4, deps-sort@1.3.8, insert-module-globals@6.4.2, and module-deps@3.7.12. Only browserify@10.1.2, browser-pack@4.0.3, deps-sort@1.3.7, insert-module-globals@6.4.3, and module-deps@3.7.11 ever referenced "jsonstream". |
NPM has confused opinions about cases of names of modules when publishing. Some operating systems are also confused by lowercase names, and the presence of JSONStream and jsonstream in the same tree is possible. However, today one bug saves us from another and npm only checks the name validation in the client! so I have published new versions of the uppercase version.
dominictarr/JSONStream#68
this issue supercedes #1247
The text was updated successfully, but these errors were encountered: