browserify applies transforms to npm linked modules

[jayphelps]

If you npm link a module into your browserify project, it incorrectly has transforms applied to it. This becomes a major issue particularly if the module you install relies on non-strict mode and you're using babelify, which inserts "use strict", causing it to error.

Here's a repo to reproduce: https://github.com/jayphelps/browserify-bug. The major step to note in the README is that you must git clone the external module and npm link it for the bug to show.

Also note that very new versions of babel proactively transform certain strict mode code, like this.foo to undefined.foo. Don't let this confuse you.

[jmm]

Hmm, I wonder if this could be from #1318.

[jayphelps]

Cc/ @chrisirhc

[jmm]

Maybe related: #1365.

[chrisirhc]

Definitely sounds like it's related to #1365. Thanks for narrowing it down. If nobody else gets to this, I'll look into it later today.

[ivantsepp]

Ah thanks for linking me to this issue @jmm!

This matches the behavior I'm seeing. The babel transform is being applied to a symlinked node_module when it shouldn't be.

[chrisirhc]

I've come up with a quick hackish solution to resolve this (browserify/module-deps#99, #1392). It's up for comment and review.

[reverofevil]

Is there any workarounds for this issue except hand-patching node_modules? Build of my project fails because of this.

[jayphelps]

switch to webpack

[reverofevil]

I've thought about it for a long time

[jmm]

Off with your heads!

@polkovnikov-ph I'm still working from the assumption that this is a result of #1318. Could you downgrade to browserify@<10.2.5 for now if that resolves it? As you wrote in the other issue, Babel's ignore option is another possibility, but that could get messy.

[chrisirhc]

@jmm, it is caused by #1318. I've submitted a fix for this as I mentioned above.

[jmm]

@chrisirhc Ok, thanks for confirming and for the PR. I haven't had a real good look at either #1318 or the new PR and I hadn't seen you say whether or not it had resulted from #1318, so I wasn't sure.

[ghost]

This is fixed in 12.0.1.

[kintel]

@substack See #1437 - I believe this should be reopened.

[TehShrike]

I encountered this issue when using browserify 12.0.1.