Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yield tests don't pass in node 8 or 9 #1784

Closed
TehShrike opened this issue Dec 20, 2017 · 7 comments
Closed

yield tests don't pass in node 8 or 9 #1784

TehShrike opened this issue Dec 20, 2017 · 7 comments

Comments

@TehShrike
Copy link
Contributor

Experienced locally with node 9, reproduced in #1783
@goto-bus-stop
Copy link
Member

goto-bus-stop commented Dec 20, 2017 •
edited

yeah i ran into this too--it looks like the error is coming from inside traceur, maybe we would have to upgrade it? i'm not sure why traceur is even used in that test honestly

@bcomnes
Copy link
Member

bcomnes commented Jan 2, 2018

Tests pass if you remove the transform. Can we do that?

@TehShrike
Copy link
Contributor Author

Only if we stop testing on node 0.10 and 0.12, I would bet.

Can we stop supporting those versions of node? 0.12 has been end-of-life for a year now.

Related: #1785 (comment)

@goto-bus-stop
Copy link
Member

removed in 183162f

@TehShrike
Copy link
Contributor Author

And node 0.10 and 0.12 were dropped in e8dbe6c. Rockin'.

@bcomnes
Copy link
Member

bcomnes commented Jan 4, 2018

Module deps also dropped 0.12 support so we should update that as well before doing a release

@TehShrike
Copy link
Contributor Author

There wasn't any version specified in package.json yet, so I opened this PR #1793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcomnes @goto-bus-stop @TehShrike