Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple stream versions galore #1999

Open
pkit opened this issue Mar 18, 2021 · 2 comments
Open

multiple stream versions galore #1999

pkit opened this issue Mar 18, 2021 · 2 comments
Assignees
Labels

Comments

@pkit
Copy link

pkit commented Mar 18, 2021

Is there any reason why stream-browserify depends on readable-stream@3.6.0 while browserify itself depends on readable-stream@^2 ?
Right now streams are kind of unusable:

  1. stream-browserify dependency tree is botched see here inheritance is botched stream-browserify#25
  2. Using readable-stream directly leads to multiple versions in the bundle which in turn leads again to no inheritance anywhere.
  3. readable-stream has inspect bug here Fix/remove node globals nodejs/readable-stream#435 (comment) which prevents me from debugging why there is any difference in Stream prototypes...

If there is no particular reason for such behavior I can create PR(s) that fix it, but maybe I'm missing something?

@legobeat
Copy link

Attempt at addressing this in #2070

@legobeat
Copy link

@pkit see #1880 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants