__dirname points to wrong package causing 'package' event to be omitted

[lukas-zech-software]

I'm using browserify 9.0.3 using module-deps 3.7.2 and my code listens on the bundle.on('package') event.
I noticed that the event is sometimes not triggered for some packages, although the package gets included properly.
It does not occur reliable even if the same code is executed twice, so it seems to be some sort of async race condition.

Example:

require('package1');
require('package2');
require('package3');

These events are fired:

bundle.on('package',function(){ //package1 });
bundle.on('package',function(){ //package3 });

I tracked the problem down to this line where the _self.emittedPkg object already contains 'package2', although the 'package' even was not yet emitted for this package.

Digging further I found that in the resolver function the following situation may occur:

// pkgdir holds the directory to 'package1'
// pkg.name holds the name of 'package2'
if (pkg && pkgdir) pkg.__dirname = pkgdir;

So it seems that the packageFilter function is called by another callback before the resolver function executes for this package? Just guessing though, I was not able to track it down further.

It seems to be similar to #67 and maybe also connected to (browserify/resolve#69)
But it differs to both issues in the fact, that __dirname does not simply point to a wrong path in the package but to a complete wrong package.

[pmowrer]

+1 Just debugged a similar scenario and came to the same conclusion (using versions 9.0.8 and 3.7.6 respectively).