From cdd0b35805f09c8b0d73f6752f7f2aa2f7c85b0d Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Sun, 27 Sep 2020 21:39:22 -0700 Subject: [PATCH] [New] add new core modules that will be in node v15 - `dns/promises`: https://github.com/nodejs/node/pull/32953 - `assert/strict`: https://github.com/nodejs/node/pull/34001 - `stream/promises`: https://github.com/nodejs/node/pull/33991 - `timers/promises`: https://github.com/nodejs/node/pull/33950 --- lib/core.js | 4 ++-- lib/core.json | 4 ++++ test/core.js | 12 ++++-------- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/core.js b/lib/core.js index 0877650c..c417d23c 100644 --- a/lib/core.js +++ b/lib/core.js @@ -6,8 +6,8 @@ function specifierIncluded(specifier) { var versionParts = (parts.length > 1 ? parts[1] : parts[0]).split('.'); for (var i = 0; i < 3; ++i) { - var cur = Number(current[i] || 0); - var ver = Number(versionParts[i] || 0); + var cur = parseInt(current[i] || 0, 10); + var ver = parseInt(versionParts[i] || 0, 10); if (cur === ver) { continue; // eslint-disable-line no-restricted-syntax, no-continue } diff --git a/lib/core.json b/lib/core.json index d51b70b1..b6695c8e 100644 --- a/lib/core.json +++ b/lib/core.json @@ -1,5 +1,6 @@ { "assert": true, + "assert/strict": ">= 15", "async_hooks": ">= 8", "buffer_ieee754": "< 0.9.7", "buffer": true, @@ -12,6 +13,7 @@ "_debugger": "< 8", "dgram": true, "dns": true, + "dns/promises": ">= 15", "domain": true, "events": true, "freelist": "< 6", @@ -49,9 +51,11 @@ "_stream_readable": ">= 0.9.4", "_stream_writable": ">= 0.9.4", "stream": true, + "stream/promises": ">= 15", "string_decoder": true, "sys": true, "timers": true, + "timers/promises": ">= 15", "_tls_common": ">= 0.11.13", "_tls_legacy": ">= 0.11.3 && < 10", "_tls_wrap": ">= 0.11.3", diff --git a/test/core.js b/test/core.js index 4c111e1d..7a3ccb16 100644 --- a/test/core.js +++ b/test/core.js @@ -22,16 +22,12 @@ test('core modules', function (t) { for (var i = 0; i < cores.length; ++i) { var mod = cores[i]; + var requireFunc = function () { require(mod); }; // eslint-disable-line no-loop-func + console.log(mod, resolve.core, resolve.core[mod]); if (resolve.core[mod]) { - st.doesNotThrow( - function () { require(mod); }, // eslint-disable-line no-loop-func - mod + ' supported; requiring does not throw' - ); + st.doesNotThrow(requireFunc, mod + ' supported; requiring does not throw'); } else { - st.throws( - function () { require(mod); }, // eslint-disable-line no-loop-func - mod + ' not supported; requiring throws' - ); + st.throws(requireFunc, mod + ' not supported; requiring throws'); } }