Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship 4.0.0 #207

Closed
2 of 4 tasks
zertosh opened this issue Apr 19, 2015 · 7 comments
Closed
2 of 4 tasks

Ship 4.0.0 #207

zertosh opened this issue Apr 19, 2015 · 7 comments

Comments

@zertosh
Copy link
Member

zertosh commented Apr 19, 2015

Before closing out 3.x:

4.0.0:

@zertosh
Copy link
Member Author

zertosh commented Apr 19, 2015

@jmm I think the 4.x line will be the last one before the row biz is figured out. So 5.0 is hopefully where we reconcile browserify + watchify + module-deps w.r.t. to the row api.

@mattdesl
Copy link
Contributor

👍

Just so I'm clear, the following will still work in 4.x correct?

var b = browserify({ cache: {}, packageCache: {} });
var w = watchify(b);

@zertosh
Copy link
Member Author

zertosh commented Apr 21, 2015

@mattdesl It will. But it I can't actually get rid of having to pass a { cache: {}, packageCache: {} } somehow into browserify like I wanted in #204 (comment).

@jmm
Copy link
Contributor

jmm commented Apr 21, 2015

@zertosh What's the upshot of that -- will watchify.args be sticking around in some form?

@zertosh
Copy link
Member Author

zertosh commented Apr 21, 2015

@jmm The cache object gets passed to module-deps when a pipeline is created (grep mopts). By the time watchify is applied to browserify, a pipeline already exists. So I'd have to dig into b.pipeline get module-deps, and modify its options object. Not cool.

But we need some form of watchify.args that creates new cache objects - like your PR. Though, that kinda sucks because if someone keeps using watchify.args, it won't break - it'll just silently not cache. Unless we do something like:

watchify.args = function() {
  return { cache: {}, packageCache: {} };
};
xtend(watchify.args, watchify.args());

But if users have to change from watchify.args to watchify.args() (or something else), maybe we should leave it as it. Instead change the documentation here, gulp, etc. to explicitly pass {cache:{}, packageCache:{}}.

@jmm
Copy link
Contributor

jmm commented Apr 21, 2015

@zertosh Ok, thanks, I figured that's what the issue was. I posted some ideas in #204 (comment).

@zertosh
Copy link
Member Author

zertosh commented May 20, 2015

Closing this out for now since things still need to be figured out in browserify regarding path matching.

@zertosh zertosh closed this as completed May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants