Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose/document parse method of caniuse-parser as part of API #34

Open
galvarez421 opened this issue Feb 29, 2020 · 2 comments
Open

Expose/document parse method of caniuse-parser as part of API #34

galvarez421 opened this issue Feb 29, 2020 · 2 comments
Assignees
@galvarez421
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@galvarez421
Copy link
Member

Given that https://github.com/browserslist/browserslist-ga-export relies on the parse method of the caniuse-parser module, would you consider a pull request to expose/document the method as part of the official API?
@dmfrancisco
Copy link
Member

Hi @galvarez421 👋 I see you're part of this organization, so I added you maintainer privileges. Feel free to make this change and thanks for contributing! 👍

@galvarez421
Copy link
Member Author

Great, thank you!

@galvarez421 galvarez421 self-assigned this Mar 20, 2020
@galvarez421 galvarez421 added the enhancement New feature or request label Mar 20, 2020
@galvarez421 galvarez421 added the help wanted Extra attention is needed label May 19, 2021
galvarez421 added a commit to browserslist/browserslist-ga-export that referenced this issue May 19, 2021
@galvarez421
Update browserslist-ga dependency
e6178be 
- We continue to specify browserslist-ga as a dependency rather than a
  peer dependency, and specifying an exact version rather than a range,
  because the parse method used internally by browserslist-ga-export is
  still not formally a part of the browserslist-ga API (see
  browserslist/browserslist-ga#34). Until
  then, we will not assume that the parse method will not be broken
  in an update regardless of the version number change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galvarez421 galvarez421

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmfrancisco @galvarez421