Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Support xhtml flag #160

Open
Truplic opened this issue Jan 25, 2019 · 3 comments
Open

Support xhtml flag #160

Truplic opened this issue Jan 25, 2019 · 3 comments
Labels
feature New feature or request

Comments

@Truplic
Copy link

Truplic commented Jan 25, 2019

It seems that webapp-webpack-plugin doesn't consider xhtml flag set in html-webpack-plugin.
This is very important for xhtml pages that need to have all tags closed.

@devlegacy
Copy link

An options is alter the result before emit, with the hook:
https://github.com/brunocodutra/webapp-webpack-plugin#webappwebpackpluginbeforeemit

And close the tags if you need it

@brunocodutra
Copy link
Owner

@Truplic Thanks for bringing this to my attention - so the expected behavior is that </link> and </meta> are added to the tags injected in the .html file, but are not visible to hooks or the loader?

Meanwhile it seems to me the approach proposed by @devlegacy would support your use case with relatively little effort.

@brunocodutra brunocodutra added the feature New feature or request label Jan 26, 2019
@Truplic
Copy link
Author

Truplic commented Jan 28, 2019

@devlegacy Thanks for the suggestion. I was able to edit the string markup in the hook.
Nevertheless, it would be more elegant to let the html-webpack-plugin do that job as it is configured.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants