Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating DataObjBytes #216

Open
bskinn opened this issue Jan 4, 2022 · 0 comments
Open

Consider deprecating DataObjBytes #216

bskinn opened this issue Jan 4, 2022 · 0 comments
Labels
area: api 🤖 issue: maybe 🤔 Being considered, but not certain type: question ❔ Something to investigate

Comments

@bskinn
Copy link
Owner

bskinn commented Jan 4, 2022

The .as_str.as_bytes &c means that each data object is automatically a reference cycle, which might hinder performance for sufficiently large inventories, due to inefficiencies in memory management.

As well, the whole DataObjBytes concept might be a YAGNI -- a/o 3 Jan 2022, there are zero GH code hits for DataObjBytes outside of the sphobjinv codebase, while there are a handful for DataObjStr.

Will be key to do memory/speed profiling here, though, as even the largest objects.inv found to date (./tests/resource/objects_yt.inv) only has ~17500 objects. Memory itself seems a much smaller concern than any repeated-GC slowness (see #217) during inventory creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api 🤖 issue: maybe 🤔 Being considered, but not certain type: question ❔ Something to investigate
Projects
None yet
Development

No branches or pull requests

1 participant