Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to fuzzywuzzy from docs #247

Open
bskinn opened this issue Oct 14, 2022 · 1 comment
Open

Remove references to fuzzywuzzy from docs #247

bskinn opened this issue Oct 14, 2022 · 1 comment
Labels
area: docs 📄 issue: maybe 🤔 Being considered, but not certain type: enhancement ✨ Something to add
Milestone

Comments

@bskinn
Copy link
Owner

bskinn commented Oct 14, 2022

If #178 ends up working out.

Main place it remains is in the API docs, but a thorough search would be good.

If the implementation of #178 ends up using the core WRatio logic of fuzzywuzzy, though, then credit will still need to be given there. Just, as a 'multiprocessing-ready re-implementation of fuzzywuzzy's method'.

@bskinn bskinn modified the milestones: v2.3, v2.4 Oct 14, 2022
@bskinn bskinn modified the milestones: v2.4, Post-2.3.1 Nov 28, 2022
@bskinn bskinn added type: enhancement ✨ Something to add issue: maybe 🤔 Being considered, but not certain labels Apr 2, 2024
@bskinn
Copy link
Owner Author

bskinn commented Apr 2, 2024

"Remove" might imply too complete an action, even if its direct influence goes away completely. The historical reliance of the project on fuzzywuzzy is still relevant, so some mention of it in some fashion, somewhere in the docs, is likely going to be warranted, no matter what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs 📄 issue: maybe 🤔 Being considered, but not certain type: enhancement ✨ Something to add
Projects
None yet
Development

No branches or pull requests

1 participant