Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Display text filters in search input #5986

Merged
merged 2 commits into from
May 23, 2024

Conversation

dennisreimann
Copy link
Member

This changes the search text input to also display the filters, which don't have a special UI (e.g. dropdown). Those filters (e.g. orderid) were not displayed before and hence could not be reset.

Fixes #5984.

grafik

This changes the search text input to also display the filters, which don't have a special UI (e.g. dropdown). Those filters (e.g. orderid) were not displayed before and hence could not be reset.

Fixes btcpayserver#5984.
@dstrukt dstrukt self-requested a review May 16, 2024 17:12
Copy link
Member

@dstrukt dstrukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as intended AFAICT.

Might not be a bad idea to get another pair of eyes on this for a bit more testing to be safe?

tACK from my end though.

@dennisreimann dennisreimann added this to the 1.13.x milestone May 22, 2024
@NicolasDorier NicolasDorier merged commit c063c70 into btcpayserver:master May 23, 2024
4 checks passed
NicolasDorier pushed a commit that referenced this pull request May 23, 2024
* Search: Display text filters in search input

This changes the search text input to also display the filters, which don't have a special UI (e.g. dropdown). Those filters (e.g. orderid) were not displayed before and hence could not be reset.

Fixes #5984.

* Add and fix test
@dennisreimann dennisreimann deleted the fix-5984 branch May 23, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug][UI]: Invoices could be permanently filtered via SearchTerm stored in cookies
3 participants