Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings error #162

Closed
Fuzzyma opened this issue May 8, 2023 · 1 comment
Closed

Typings error #162

Fuzzyma opened this issue May 8, 2023 · 1 comment

Comments

@Fuzzyma
Copy link

Fuzzyma commented May 8, 2023

I am using vite and just upgraded from 4.0.x to 4.3.x. It turns out that the typings must have changed because typechecks fail now:

grafik

Type 'import("/my/path/node_modules/rollup/dist/rollup").ObjectHook<(this: import("/my/path/node_modules/rollup/dist/rollup").PluginContext, options: import("/my/path/node_modules/rollup/dist/rollup").NormalizedOutputOptions, bundle: import("/my/path/node_modules/rollup/dist/rollup").OutputBundle, isWrite: boolean) => void | Promise<void>, {}> | undefined' is not assignable to type 'import("/my/path/node_modules/vite/node_modules/rollup/dist/rollup").ObjectHook<(this: import("/my/path/node_modules/vite/node_modules/rollup/dist/rollup").PluginContext, options: import("/my/path/node_modules/vite/node_modules/rollup/dist/rollup").NormalizedOutputOptions, bundle: import("/my/path/node_modules/vite/node_modules/rollup/dist/rollup").OutputBundle, isWrite: boolean) => void | Promise<void>, {}> | undefined'.
@btd
Copy link
Owner

btd commented May 8, 2023

Yes it is know issue of vite. In rollup 3.x was a breaking change in types. Vite copied types from rollup, but did not specified version.
Just add casting to PluginOptions
See #124 and #127

@btd btd closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants