Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we enable keyboard support to this package? #40

Open
arunmmanoharan opened this issue Sep 23, 2019 · 2 comments
Open

Can we enable keyboard support to this package? #40

arunmmanoharan opened this issue Sep 23, 2019 · 2 comments

Comments

@arunmmanoharan
Copy link

Hi,

I was trying out a few map packages and this is the best I've seen. I work on a project where keyboard and screen reader support is of more importance. Is there a way we/you can implement this?

Looking forward to your thoughts.

Currently react-simple-maps supports just keyboard navigation using tabs alphabetically by state.

@btmills
Copy link
Owner

btmills commented Sep 24, 2019

This aims to be a very thin wrapper around https://github.com/markmarkoh/datamaps, so I'd be happy to accept a pull request that enables anything that already exists in that project.

For some historical perspective, I created this to migrate an existing project that used datamaps to React with as little re-writing as possible. react-simple-maps looks like a really nice API, so if I ever need to build something else with maps, I'll take a look at that - thanks for the tip!

@arunmmanoharan
Copy link
Author

Thanks man. Appreciate the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants