Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Hazelcast documentation for 7.x & 8.x docs #285

Closed
abelsromero opened this issue Aug 3, 2022 · 3 comments
Closed

Invalid Hazelcast documentation for 7.x & 8.x docs #285

abelsromero opened this issue Aug 3, 2022 · 3 comments

Comments

@abelsromero
Copy link
Contributor

I am working on an upgrade from v6 and I found the docs are not valid.
They state the BucketConfiguration build method requires 2 params, but it has 0.

image

The key is not passes to the BucketConfiguration builder but to the Bucket builder.
@abelsromero
Copy link
Contributor Author

If it's ok, this is an easy fix, I can work on the current asciidoctor branch alongside other minnor doc fixes.

@vladimir-bukhtoyarov
Copy link
Collaborator

Yes, it is bug, right example should be as you described above.

abelsromero added a commit to abelsromero/bucket4j that referenced this issue Aug 4, 2022
@abelsromero
bucket4j#285 Update Hazelcast Bucket instantiation
048def3
vladimir-bukhtoyarov added a commit that referenced this issue Aug 5, 2022
@vladimir-bukhtoyarov
Merge pull request #289 from abelsromero/fix-docs-hazelcast-code-exam…
ebe0ee5 
…ples

#285 Update Hazelcast Bucket instantiation
@vladimir-bukhtoyarov
Copy link
Collaborator

documentation has been fixed for 7.6.0 and 8.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abelsromero @vladimir-bukhtoyarov