Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal lint rule: .convertParsed and .addedImports #501

Open
JoshuaKGoldberg opened this issue Oct 27, 2018 · 0 comments
Open

Internal lint rule: .convertParsed and .addedImports #501

JoshuaKGoldberg opened this issue Oct 27, 2018 · 0 comments
Labels
linting source quality

Comments

@JoshuaKGoldberg
Copy link
Member

Following #500: whenever this.context.convertParsed is called, the .addedImports should be used. It'd be nice to have an internal GLS-specific TSLint rule to enforce this.

Vaguely similar to the idea behind no-floating-promises, if that particular method is called, either the direct object must be returned or the .addedImports section used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linting source quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg