Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-Table, first row not filtered out when one of multiple filters are cleared #3599

Closed
Verdoso opened this issue Nov 25, 2021 · 0 comments
Closed
Assignees
Labels

Comments

@Verdoso
Copy link

Verdoso commented Nov 25, 2021

Overview of the problem

Hello there,
Here is the issue I'm seeing: when you filter a table through more than one header and then remove one of the criteria, the first row of the data always appears as if it matched the criteria, even if it does not match. If you simply "refresh" the filter (by adding and then removing a character) then the first row correctly disappears.

Steps to reproduce

To reproduce it, one can use this codepen: https://codepen.io/Verdoso/pen/yLodwJa?editors=1010

  1. Set 's' as the filter for the 'Last Name' column
  2. Set 'Jo' as the filter for the 'First Name' column
  3. Go back to column 'Last Name' and remove the filter
  4. You will see you have now two rows with names Jesse and John. Jesse SHOULD NOT be there as it does not contain 'Jo'
  5. Add a space to the 'First Name' column filter and remove it, you'll see that the Jesse row disappears and the filtering now works correctly.

imagen
2)
imagen
3 & 4)
imagen
5)
imagen

The "extra" row appears to be always the first row of the table (based on order). I'm seeing it in multiple instances of the table in various applications and with or without custom search filters.

Buefy version: 0.9.13
Vuejs version: 2.6.14
OS/Browser: Tested in Windows with current Firefox/Chrome browsers.

Expected behavior

Once the second filter is removed, I would expect the remaining filter to be applied and just see the rows that match the criteria.

Actual behavior

A row that does not match the filter is always added as first row, and it happens to be the first row that would be displayed if there was no filter.

Cheers!

@jtommy jtommy added the bug label Nov 25, 2021
@jtommy jtommy self-assigned this Nov 25, 2021
@jtommy jtommy closed this as completed in 5f8e126 Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants