fix: Request body deserialization fix in IAdmissionWebhook (#533)

tomasfabian · web-flow · commit be27d6c7c91e · 2023-02-22T16:52:27.000+07:00
fixes #531
diff --git a/src/KubeOps/Operator/Webhooks/IAdmissionWebhook{TEntity, TResult}.cs b/src/KubeOps/Operator/Webhooks/IAdmissionWebhook{TEntity, TResult}.cs
@@ -107,7 +107,10 @@ internal void Register(IEndpointRouteBuilder endpoints) =>
                     return;
                 }
 
-                var review = KubernetesJson.Deserialize<AdmissionReview<TEntity>>(context.Request.Body.ToString());
+                using var reader = new StreamReader(context.Request.Body);
+                var requestBody = await reader.ReadToEndAsync();
+
+                var review = KubernetesJson.Deserialize<AdmissionReview<TEntity>>(requestBody);
 
                 if (review.Request == null)
                 {

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,10 @@ internal void Register(IEndpointRouteBuilder endpoints) =>`
`107`	`107`	`return;`
`108`	`108`	`}`
`109`	`109`
`110`		`- var review = KubernetesJson.Deserialize<AdmissionReview<TEntity>>(context.Request.Body.ToString());`
	`110`	`+ using var reader = new StreamReader(context.Request.Body);`
	`111`	`+ var requestBody = await reader.ReadToEndAsync();`
	`112`	`+`
	`113`	`+ var review = KubernetesJson.Deserialize<AdmissionReview<TEntity>>(requestBody);`
`111`	`114`
`112`	`115`	`if (review.Request == null)`
`113`	`116`	`{`